Project

General

Profile

Bug #18179

unit test test_glideFactoryDowntimeLib.py failing

Added by Marco Mambelli over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
High
Category:
-
Target version:
Start date:
11/09/2017
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

Since a couple of days 2 tests within test_glideFactoryDowntimeLib.py have been failing.
No code changed in this library in a long time (years).
Looking at the code it seems the problem is related to the switch from CDT to CST which is why it became visible now.

History

#1 Updated by Marco Mambelli over 2 years ago

  • Status changed from New to Feedback
  • Assignee changed from Marco Mambelli to Dennis Box
  • Priority changed from Normal to High

changes in v3/18179
Still not handling some corner cases (times in the past with DST temporary rules switched during the year) but a better solution would be much more complex (using time zone libraries directly) and this is good enough for downtimes, that will be in the future

For more details see the links in the code comments:
  1. time.daylight tells only if the computer support daylight saving time,
  2. tm_isdst must be checked to see if it is in effect at time t
  3. Some corner cases (changes in standard) are still uncovered, see https://bugs.python.org/issue1647654
  4. See also https://bugs.python.org/issue7229 for an improved explanation of the Python manual wording

#2 Updated by Dennis Box over 2 years ago

OK to merge

#3 Updated by Dennis Box over 2 years ago

  • Assignee changed from Dennis Box to Marco Mambelli

#4 Updated by Marco Mambelli over 2 years ago

  • Status changed from Feedback to Resolved

#5 Updated by Marco Mambelli over 2 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF