Project

General

Profile

Bug #1809

Unnecessary hardwired path in setup/setup_novasoft_nusoft.{,c}sh

Added by Christopher Green over 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
09/07/2011
Due date:
% Done:

100%

Estimated time:
Duration:

Description

The invalid release checking in these scripts is unnecessarily sensitive to the full path of the NOvA setup. This can be ameliorated easily with the following fix:

diff -u -r1.8 setup_novasoft_nusoft.csh
--- setup_novasoft_nusoft.csh   1 Sep 2011 18:33:24 -0000       1.8
@@ -42,7 +42,7 @@
        # csh-compatible.  Pass along any arguments to this script.
        set result=`${SETUP_LOCATION}/setup_novasoft_setup_nusoft.sh -c $argv`
        # Make sure provided argument is and existing release
-       if ( ! -d "/grid/fermiapp/nova/novaart/novasoft/releases/$2" ) then
+       if ( ! -d "${SETUP_LOCATION}/../releases/$2" ) then
             echo "INVALID RELEASE. Try sourcing again with a valid release name." 
              setenv INVALID_RELEASE 1
         endif
diff -u -r1.5 setup_novasoft_nusoft.sh
--- setup_novasoft_nusoft.sh    1 Sep 2011 18:33:24 -0000       1.5
+++ setup_novasoft_nusoft.sh    7 Sep 2011 14:59:15 -0000
@@ -40,7 +40,7 @@
         # sh-compatible.  Pass along any arguments to this script.
        result=`${SETUP_LOCATION}/setup_novasoft_setup_nusoft.sh -s $@`
        # Make sure provided argument is and existing release
-        if [ ! -d "/grid/fermiapp/nova/novaart/novasoft/releases/$2" ]; then
+        if [ ! -d "${SETUP_LOCATION}/../releases/$2" ]; then
             echo "INVALID RELEASE. Try sourcing again with a valid release name." 
             export INVALID_RELEASE=1
         fi

I'd be grateful if you could make the appropriate changes.

Thanks,
Chris.

History

#1 Updated by Gavin Davies over 8 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

I've made the necessary change to the setup scripts to lessen the sensitivity to the novasoft setup location. Thanks for pointing this out go to Chris Green.

#2 Updated by Gavin Davies about 8 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF