Project

General

Profile

Feature #18027

Add skipped files to pylint tests

Added by Marco Mambelli over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
10/25/2017
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

Vito pointed out that the number of files checked in pylint Is lower than in futurize.
So I checked the script and it limits to some directory so these .py files are not covered:

Some init.py (don’t seem to have important code, OK to check it only if the dir is checked)

Then these files in these directories are not checked:
./build/ReleaseManager/release.py
./build/ReleaseManager/ReleaseManagerLib.py
./creation/web_base/update_proxy.py
./factory/tools/cat_logs.py
./factory/tools/cat_MasterLog.py
./factory/tools/cat_StartdHistoryLog.py
./factory/tools/cat_StartdLog.py
./factory/tools/cat_StarterLog.py
./factory/tools/cat_XMLResult.py
./factory/tools/configGUI.py
./factory/tools/find_ids_not_published.py
./factory/tools/find_logs.py
./factory/tools/find_matching_ids.py
./factory/tools/find_missing_ids.py
./factory/tools/find_new_entries.py
./factory/tools/find_partial_matching_ids.py
./factory/tools/find_StartdLogs.py
./factory/tools/infosys_lib.py
./factory/tools/lib/analyze.py
./factory/tools/lib/gWftArgsHelper.py
./factory/tools/lib/gWftLogParser.py
./factory/tools/manual_glidein_submit.py
./frontend/tools/lib/frontenvparse.py
./install/services/Certificates.py
./install/services/common.py
./install/services/Condor.py
./install/services/Configuration.py
./install/services/Factory.py
./install/services/Glidein.py
./install/services/PrivilegeSeparation.py
./install/services/RPM.py
./install/services/Submit.py
./install/services/UserCollector.py
./install/services/VDT.py
./install/services/VDTClient.py
./install/services/VOFrontend.py
./install/services/WMSCollector.py
./unittests/test_cleanupSupport.py
./unittests/test_condorExe.py
./unittests/test_encodingSupport.py
./unittests/test_frontend.py
./unittests/test_frontend_element.py
./unittests/test_glideFactoryDowntimeLib.py
./unittests/test_glideFactoryLogParser.py
./unittests/test_glideinFrontendPlugins.py
./unittests/test_infosys_lib.py
./unittests/test_logSupport.py
./unittests/test_tarSupport.py
./unittests/unittest_utils.py
./unittests/worker_scripts/log_writer.py
./unittests/worker_scripts/master_writer.py
./unittests/worker_scripts/write_exit_0.py
./unittests/worker_scripts/write_exit_1.py

After talking to Parag, we cncluded there is no special reason to skip these files, so they need to be added

History

#1 Updated by Marco Mambelli about 2 years ago

  • Target version changed from v3_2_21 to v3_2_22

#2 Updated by Marco Mambelli almost 2 years ago

  • Status changed from New to Work in progress
  • Assignee set to Marco Mambelli

branch v3/10827

#3 Updated by Marco Mambelli almost 2 years ago

Code is in v3/18027
Pep8 is now called pycodestyle. pep8 is still used in variable names and logging, but the package and executable have been updated

#4 Updated by Marco Mambelli almost 2 years ago

  • Status changed from Work in progress to Feedback
  • Assignee changed from Marco Mambelli to Dennis Box

#5 Updated by Dennis Box almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Dennis Box to Marco Mambelli

#6 Updated by Marco Mambelli almost 2 years ago

  • Target version changed from v3_2_22 to v3_2_23

#7 Updated by Marco Mambelli almost 2 years ago

  • Target version changed from v3_2_23 to v3_4_0

#8 Updated by Marco Mambelli over 1 year ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF