Project

General

Profile

Task #18007

handling of comments in test_runner script when parsing the ci_tests.cfg configuration file

Added by Vito Di Benedetto over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
10/23/2017
Due date:
% Done:

100%

Estimated time:
Duration:

Description

If the ci_tests.cfg configuration file has lines which are mixed of parameters set and comments the CI tests could not behave properly.

It would be good to prevent to have those mixed line in the ci_tests.cfg configuration file raising an exception.

For example lines like:

args=--executable lar --nevents %(NEVENTS)s --stage %(STAGE)s --stage-name %(STAGE_NAME)s --fhicl %(FHiCL_FILE)s --outputs %(OUTPUT_STREAM)s --testmask %(TESTMASK)s  # --reference-files %(REFERENCE_FILES)s

or

args=--executable lar --nevents %(NEVENTS)s --stage %(STAGE)s --stage-name %(STAGE_NAME)s --fhicl %(FHiCL_FILE)s --outputs %(OUTPUT_STREAM)s --testmask %(TESTMASK)s  ; --reference-files %(REFERENCE_FILES)s

where "#" or ";" are used to comment part of the configuration line, this should raise an exception.

History

#1 Updated by Bruno Coimbra over 1 year ago

  • Status changed from Assigned to Resolved

Now an exception is raised when "#" is found in a configuration parameter.
To comply with Python ConfigParser policy, inline comments are allowed with ";".

Changes on branch feature/coimbra_handle_comments

#2 Updated by Bruno Coimbra over 1 year ago

  • % Done changed from 0 to 100

#3 Updated by Vito Di Benedetto over 1 year ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF