Necessary Maintenance #18002
Missing override directives in detinfo::LArPropertiesStandard
Experiment:
-
Description
While ROOT is processing lardata:source:lardata/DetectorInfo/LArPropertiesStandard.h, Clang complains of:
/grid/fermiapp/products/larsoft/lardata/v06_30_00/include/lardata/DetectorInfo/LArPropertiesStandard.h:185:18: warning: 'ExtraMatProperties' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual bool ExtraMatProperties() const { return fExtraMatProperties; } ^ /grid/fermiapp/products/larsoft/lardata/v06_30_00/include/lardata/DetectorInfo/LArProperties.h:72:20: note: overridden virtual function is here virtual bool ExtraMatProperties() const = 0; ^ /grid/fermiapp/products/larsoft/lardata/v06_30_00/include/lardata/DetectorInfo/LArPropertiesStandard.h:186:20: warning: 'TpbTimeConstant' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual double TpbTimeConstant() const { return fTpbTimeConstant; } ^ /grid/fermiapp/products/larsoft/lardata/v06_30_00/include/lardata/DetectorInfo/LArProperties.h:73:22: note: overridden virtual function is here virtual double TpbTimeConstant() const = 0;
History
#1 Updated by Gianluca Petrillo about 3 years ago
- Category set to Library
Probably the solution is simply to add the override
keyword as suggested by the compiler.
#2 Updated by Lynn Garren about 3 years ago
- Status changed from New to Assigned
- Assignee set to Lynn Garren
const becomes const override
#3 Updated by Lynn Garren about 3 years ago
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
Resolved with commit a305e864601d88d166f545fd25c3ed37461c1d5f
#4 Updated by Lynn Garren almost 3 years ago
- Status changed from Resolved to Closed