Project

General

Profile

Necessary Maintenance #17672

Remove deprecated lar::PtrMaker alias

Added by Gianluca Petrillo about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Library
Target version:
-
Start date:
09/07/2017
Due date:
10/12/2017
% Done:

100%

Estimated time:
Spent time:
Experiment:
LArSoft
Duration: 36

Description

I have added a temporary alias for art::PtrMaker so that the code using lar::PtrMaker emits a warning.

After a reasonable transition period, the header lardata/Utilities/PtrMaker.h itself should be removed.

Associated revisions

Revision df2f0920 (diff)
Added by Gianluca Petrillo about 3 years ago

Temporary legacy version of lar::PtrMaker for transition time.

Tracked by issue #17672.

Revision 95653e66 (diff)
Added by Gianluca Petrillo about 3 years ago

Temporary legacy version of lar::PtrMaker for transition time.

Tracked by issue #17672.

Revision 71152931 (diff)
Added by Gianluca Petrillo almost 3 years ago

Removed legacy header lardata/Utilities/PtrMaker.h .

This completes the resolution of issue #17672.

History

#1 Updated by Gianluca Petrillo about 3 years ago

  • Description updated (diff)
  • Due date set to 10/12/2017
  • Category set to Library
  • Experiment LArSoft added
  • Experiment deleted (-)

Update instructions

In the C++ code, whenever appears:

  • change the include directive from
    #include "lardata/Utilities/PtrMaker.h"
    to
    #include "art/Persistency/Common/PtrMaker.h"
  • change the namespace of PtrMaker from
    lar::PtrMaker
    to
    art::PtrMaker

No additional library needs to be linked (PtrMaker.h is header only).

#2 Updated by Lynn Garren about 3 years ago

Please run the provided script v06_49_00-PtrMakerInArt.sh to make these changes.

#3 Updated by Gianluca Petrillo about 3 years ago

Change of direction: no more legacy alias, the code just breaks.
When including the header, a message will inform about the instructions to fix the problem (ending up to this ticket).

The header should be removed after a while.

#4 Updated by Lynn Garren about 3 years ago

  • Status changed from New to Assigned
  • Assignee set to Gianluca Petrillo

#5 Updated by Gianluca Petrillo almost 3 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

The legacy header is removed in branch feature/gp_Issue17672 of lardata, scheduled for merge in this week release (after v06_55_00).

#6 Updated by Gianluca Petrillo almost 3 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF