Adding geo::kX view and TimeOffsetX to DetectorProperties for rotated dual phase geometry gives segmentation faul from trajcluster and pmtrack
When loading the rotated protodune dual phase geometry (dunetpc/dune/Geometry/gdml/protodunedphase_rot.gdml) with drift in y and views in x (geo::View_t = geo::kX = 4) and z (geo::View_t = geo::kZ = 2), I got the following error:
%MSG-s ArtException: lar 16-May-2017 23:18:17 CEST JobSetup cet::exception caught in art ---- OtherArt BEGIN ServiceCreation ---- CalculateXTicksParams BEGIN Bad view = 4 ---- CalculateXTicksParams END cet::exception caught during construction of service type detinfo::DetectorPropertiesServiceStandard: ---- OtherArt END %MSG
The problem is that the
geo::kX case (and
TimeOffsetX) is not implemented in
I added them, see branch
Files I changed:
The rotated geometry is loading with this fix (I can't test much more right now since the drift in y is not implemented yet at the g4 stage), but:
When loading the unrotated dual phase geometry (
dunetpc/dune/Geometry/gdml/protodunedphase.gdml, with drift in x and views in y and z) with this fix, I get a segmentation fault from
linecluster works). To reproduce, checkout my branch in
lardata and do:
reco with raw hit finding and
lar -c srcs/dunetpc/fcl/protodunedp/gen/prod_protodunedp.fcl -n 1 -o gen.root (no problem) lar -c srcs/dunetpc/fcl/protodunedp/g4/standard_g4_protodunedp.fcl gen.root -o g4.root (no problem) lar -c srcs/dunetpc/fcl/protodunedp/detsim/standard_detsim_protodunedp.fcl g4.root -o detsim.root (no problem) lar -c srcs/dunetpc/fcl/protodunedp/reco/rawhitfinding_reco_protodunedp.fcl detsim.root -o reco.root (segmentation fault from trajcluster)
reco with gauss hit finding and linecluster:
lar -c srcs/dunetpc/fcl/protodunedp/gen/prod_protodunedp.fcl -n 1 -o gen.root (no problem) lar -c srcs/dunetpc/fcl/protodunedp/g4/standard_g4_protodunedp.fcl gen.root -o g4.root (no problem) lar -c srcs/dunetpc/fcl/protodunedp/detsim/standard_detsim_protodunedp.fcl g4.root -o detsim.root (no problem) lar -c srcs/dunetpc/fcl/protodunedp/reco/standard_reco_protodunedp.fcl detsim.root -o reco.root (segmentation fault from pmtrack)
Both reconstructions work fine without the fix.
Let me know if you need more information!
#1 Updated by Gianluca Petrillo about 3 years ago
- Status changed from New to Assigned
- Assignee set to Gianluca Petrillo
Thank you for reporting this, Christoph.
Actually, the work was already done, but was lying on a feature branch that has been forgotten:
I have picked a couple of changes that I had missed (or that I had opted not to adopt, but that make sense to me now).
I have not picked the changes to the FHiCL file. In fact, I wish I could safely remove the other
TimeOffset# settings from that FHiCL file: they are detector-specific and it makes no sense to have them in a generic configuration.