Project

General

Profile

Necessary Maintenance #17194

Create a location for art-independent service provider detinfo::DetectorClocks

Added by Gianluca Petrillo almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Library
Target version:
-
Start date:
07/17/2017
Due date:
% Done:

100%

Estimated time:
Spent time:
Experiment:
-
Duration:

Description

To be able to support reconstruction algorithms in development environments without the art framework, with gallery as the benchmark, service providers need to be made available in such environment.
With geo::GeometryCore already settled in larcorealg, the next lowest level service providers in the hierarchy are the ones in detinfo namespace, which currently live in lardata directory lardata/DetectorInfo.

A proper place needs to bee agreed upon to set those providers in.


Related issues

Related to LArSoft - Meeting #18283: Define a policy for LArSoft art-independent code and repositoriesClosed11/15/2017

Blocks LArSoft - Feature #17179: Make standard detector clocks available in gallery environmentClosed07/13/2017

Precedes LArSoft - Necessary Maintenance #19138: Update wiki pages to reflect the new repository structureAccepted07/18/201707/18/2017

History

#1 Updated by Gianluca Petrillo almost 3 years ago

A preliminary discussion has outlined some points for consideration:

  • the approach of having the code base organised in small units was deemed desirable, despite the fact that our current developing environment does not makes it seamless
  • the organisation of such units does not have to necessarily follow the current LArSoft one (e.g. core, data, event, etc.)
  • a level of service providers dealing with detector "conditions" is useful and might be accommodated in the same unit
  • there is a feeling that the geometry provider is not at that same level (but in fact lower)
  • there is also the feeling that channel status, pedestal levels and other more obviously database-driven providers also do not belong to the same level, but rather to a higher one

#2 Updated by Gianluca Petrillo almost 3 years ago

A possible starting point for the discussion leading to the final decision may be the following:

  • introduction in the "alg" hierarchy of a new repository, lardetectorprov (the name is less than tentative... more like a placeholder)
  • population of that repository with:
    • service provider interfaces for detinfo::LArProperties, detinfo::DetectorClocks and detinfo::DetectorClocks
    • reference implementation of these service provider interfaces: detinfo::LArPropertiesStandard, detinfo::DetectorClocksStandard and detinfo::DetectorClocksStandard
    • any utility from lardata required to have those implementations work
  • the repository will depend on larcorealg (and on larcoreobj)
  • the repository will not depend on lardataobj: such a dependency is not ruled out for the future, but unnecessary1 so far.

The repository would be distributed with LArSoft bundle, and with every bundle already including larcorealg.


1 The current code has a ghost dependency on lardataobj/RawData/TriggerData.h that appears not to be used.

#3 Updated by Gianluca Petrillo almost 3 years ago

  • Blocks Feature #17179: Make standard detector clocks available in gallery environment added

#4 Updated by Lynn Garren almost 3 years ago

  • Status changed from New to Assigned

#5 Updated by Gianluca Petrillo over 2 years ago

  • Status changed from Assigned to Feedback

Need input from the team on the proposal.

#6 Updated by Gianluca Petrillo over 2 years ago

#7 Updated by Gianluca Petrillo over 2 years ago

#8 Updated by Gianluca Petrillo over 2 years ago

  • Related to Meeting #18283: Define a policy for LArSoft art-independent code and repositories added

#9 Updated by Gianluca Petrillo over 2 years ago

#10 Updated by Katherine Lato over 2 years ago

  • Status changed from Feedback to Assigned

#11 Updated by Lynn Garren about 2 years ago

  • Assignee changed from Gianluca Petrillo to Lynn Garren
  • % Done changed from 0 to 100

lardataalg was identified some time ago as the appropriate place for this work. This repository contains a skeleton and no code yet. I made sure the skeleton is up to date and double checked that it has the same permissions as the other larsoft repositories.

#12 Updated by Lynn Garren about 2 years ago

  • Status changed from Assigned to Resolved

DetectorClocks is now in larcorealg

#13 Updated by Lynn Garren about 2 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF