Project

General

Profile

Feature #17087

Hermetic error message on mismatching product ID and data type

Added by Gianluca Petrillo about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Navigation
Target version:
Start date:
06/29/2017
Due date:
% Done:

100%

Estimated time:
8.00 h
Spent time:
Scope:
Internal
Experiment:
LArSoft
SSI Package:
art
Duration:

Description

I just used art::Event::get() specifying a product ID and a handle to the wrong data type. My bad, and good that art threw a LogicError exception. The message, though:

%MSG-s ArtException:  PostEndJob 29-Jun-2017 16:59:22 CDT ModuleEndJob
cet::exception caught in art
---- OtherArt BEGIN
  ---- EventProcessorFailure BEGIN
    EventProcessor: an exception occurred during current event processing
    ---- EventProcessorFailure BEGIN
      EndPathExecutor: an exception occurred during current event processing
      ---- ScheduleExecutionFailure BEGIN
        Path: ProcessingStopped.
        ---- LogicError BEGIN
          Handle<T> c'tor cet::exception going through module
        ---- LogicError END
        Exception going through path end_path
      ---- ScheduleExecutionFailure END
    ---- EventProcessorFailure END
  ---- EventProcessorFailure END
---- OtherArt END
%MSG

could have been clearer. Something like "product ID 1:2 contains 'std::vector<Blah>' and can't be read via Handle<std::vector<Oops>>." or so.


Seen in art v2_07_03.

History

#1 Updated by Marc Paterno about 2 years ago

  • Category set to Navigation
  • Status changed from New to Assigned
  • Assignee set to Kyle Knoepfel
  • Estimated time set to 8.00 h
  • Experiment LArSoft added
  • Experiment deleted (-)
  • SSI Package art added

We will improve the information content of the error message.

#2 Updated by Kyle Knoepfel about 2 years ago

  • Status changed from Assigned to Accepted

Upon further investigation, we have determined that the context system must be revised to be able to provide more helpful information. Doing such a revision is slated to be part of the multi-threading endeavor.

#3 Updated by Kyle Knoepfel about 2 years ago

  • Blocked by Feature #15388: Put context information into exceptions in the places where framework code intercepts them added

#4 Updated by Kyle Knoepfel almost 2 years ago

  • Has duplicate Bug #17556: Missing module label in exception message added

#5 Updated by Kyle Knoepfel almost 2 years ago

  • Blocked by deleted (Feature #15388: Put context information into exceptions in the places where framework code intercepts them)

#6 Updated by Kyle Knoepfel almost 2 years ago

  • Status changed from Accepted to Resolved
  • Target version set to 2.09.00
  • % Done changed from 0 to 100

It turns out that resolving this issue was simpler than I feared. Implemented with commit art:f7d41778.

#7 Updated by Kyle Knoepfel almost 2 years ago

  • Has duplicate deleted (Bug #17556: Missing module label in exception message)

#8 Updated by Kyle Knoepfel almost 2 years ago

  • Target version changed from 2.09.00 to 2.08.03

#9 Updated by Kyle Knoepfel almost 2 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF