Necessary Maintenance #16812
Remove DUNE-specific code from GeometryGeo
Start date:
06/12/2017
Due date:
% Done:
100%
Estimated time:
8.00 h
Experiment:
-
Description
The code in geo::CryostatGeo
constructor has hard-coded logic to determine whether to use a special, DUNE FD sorting for optical detectors.
This should be replaced by a virtual call to the proper sorter in geo::CryostatGeo::SortSubVolumes()
.
That infrastructure has still to be created, but it should be straightforward to expand the current geo::GeoObjectSorter
structure to include it.
History
#1 Updated by Lynn Garren over 3 years ago
- Status changed from New to Assigned
- Assignee set to Gianluca Petrillo
LArSoft will provide an optical detector sorter interface. It will be up to the experiments to use the sorter interface.
#2 Updated by Gianluca Petrillo over 3 years ago
- Estimated time set to 8.00 h
#3 Updated by Gianluca Petrillo over 3 years ago
- Description updated (diff)
#4 Updated by Katherine Lato over 2 years ago
- Assignee changed from Gianluca Petrillo to Saba Sehrish
#5 Updated by Saba Sehrish almost 2 years ago
Following changes have been made:
- A new virtual function has been added to the
geo::GeoObjectSorter
class -virtual void SortOpDets(std::vector<geo::OpDetGeo*> & opdet) const;
.
It is not made a pure virtual function and base implementation is provided in the corresponding cxx file. - The generic sort order function in
larcorealg/larcorealg/Geometery/CryostatGeo.cxx
,opdet_sort
is renamed tosortorderOpDets
and moved tolarcorealg/larcorealg/Geometry/GeoObjectSorter.cxx
. The implementation ofSortOpDets
that uses this sort order has been added to thelarcorealg/larcorealg/Geometry/GeoObjectSorter.cxx
. - The
SortOpDets
function is now called in thegeo::CryostatGeo::SortSubVolumes()
. - The dune specific code has been removed from inside the
geo::CryostatGeo
constructor inlarcorealg/larcorealg/Geometery/CryostatGeo.cxx
. The function namedDUNE_opdet_sort
now renamedsortorderOpDet
and is moved to a headerdunetpc/dune/Geometry/OpDetSorter.h
.
This Dune specific sortorder for the caseOpDets.size() > 600
is used in the implementation ofSortOpDets
for the following two GeoObjectSorters:dunetpc/dune/Geometry/GeoObjectSorterCRM.h
anddunetpc/dune/Geometry/GeoObjectSorterAPA.h
.
#6 Updated by Kyle Knoepfel almost 2 years ago
- % Done changed from 0 to 100
- Status changed from Assigned to Resolved
In release v08_12_00.