Project

General

Profile

Bug #16625

Proposed patches for compile errors on macOS/Clang

Added by Ben Morgan about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
05/23/2017
Due date:
% Done:

100%

Estimated time:
Spent time:
Duration:

Description

The attached patches resolve some compile errors for cetlib code on macOS Sierra (Xcode 8) as of 803ab215.

I believe 0001 and 0002 are valid C++ Standard issue that GCC allows or works around, 0003 I'm not certain about. All tests(*) pass on this platform, but I've not been able to check on Linux yet. Also, the change in 0003 may have implications for upstream clients if it is a Clang issue rather than C++ Standard related.

(*) Plugin tests that use the default search path fail as expected - but these do not use the code touched by the patches.

History

#1 Updated by Kyle Knoepfel about 3 years ago

  • Status changed from New to Resolved
  • Assignee set to Kyle Knoepfel
  • % Done changed from 0 to 100

All of the patches you provided caught genuine C++ errors. The patches applied cleanly. Thank you.

Implemented with commit cetlib:75e9aca.

#2 Updated by Kyle Knoepfel about 3 years ago

  • Target version set to 1209

#3 Updated by Kyle Knoepfel about 3 years ago

  • Target version changed from 1209 to 2.07.01

#4 Updated by Kyle Knoepfel about 3 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF