Project

General

Profile

Bug #16410

Clarify attribute types and globbing behavior

Added by Marco Mambelli over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
High
Category:
-
Target version:
Start date:
05/03/2017
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

If an attribute contains an asterisk, it is expanded on the worker node. This could be a desired effect but the user should be warned.
There is no mention of how attributes are split and globbed.

If the user does not like expansion, e.g. in the following expression:
<attr name="SlotWeight" glidein_publish="True" job_publish="False" parameter="True" type="string" value="(Cpus + ifThenElse(TotalSlotMemory > (TotalMemory / TotalCpus * Cpus), (TotalSlotMemory - (TotalMemory / TotalCpus * Cpus)) / (TotalMemory / TotalCpus), 0))"/>

1. Should the user add quotes (e.g. "\"expression\"" or ' "expression' ")?
2. Should the system avoid the globbing (this would make it impossible also if the use desires it, e.g. to expand a directory or list of files on the worker node)?

The current situation where variables are expanded but this is not documented should be fixed following 1 or 2.

The documentation is also a bit confusing and should be straightened up.
As I said it does not mention wether strings and expressions should be quoted or not.
Furthermore the allowed types are confusing.

GlideinWMS allows attributes in frontend and factory configuration:
http://glideinwms.fnal.gov/doc.prd/frontend/configuration.html#attrs
http://glideinwms.fnal.gov/doc.prd/factory/configuration.html#attrs
http://glideinwms.fnal.gov/doc.prd/factory/custom_vars.html

The types "are 'int', 'string' and 'expr'. Type expr is equivalent to condor constant/expression in condor_vars.lst"
But in the 3rd document is used: I – integer, S – quoted string, C – unquoted string (i.e. Condor keyword or expression)
And in the column also Bool and List are used, probably should be Expr (Bool) / Expr(List)

History

#1 Updated by Marco Mambelli over 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Marco Mambelli to Parag Mhashilkar

changes in v3/16410

#2 Updated by Parag Mhashilkar over 3 years ago

  • Assignee changed from Parag Mhashilkar to Marco Mambelli

Looks ok to merge

#3 Updated by Marco Mambelli over 3 years ago

  • Status changed from Feedback to Resolved

#4 Updated by Parag Mhashilkar over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF