Support #16096: Fix problems found when attempting to build with gcc 6.3.0
problem building uboonecode/uboone/CalData/NoiseFilterAlgs with gcc 6.3.0
Both uboone/CalData/NoiseFilterAlgs/RawDigitCorrelatedCorrectionAlg.cc and uboone/CalData/NoiseFilterAlgs/RawDigitFFTAlg.cxx contain variable length arrays.
Changes required to fix uboone/CalData/NoiseFilterAlgs/RawDigitCorrelatedCorrectionAlg.cc are straightforward, and a tentative fix may be found in branch feature/team_for_gcc630.
However uboone/CalData/NoiseFilterAlgs/RawDigitFFTAlg.cxx is quite complex and the required changes are nontrivial. This will need to be fixed by an expert.
#1 Updated by Tracy Usher over 3 years ago
The reason RawDigitFFTAlg uses variable length arrays is because it is using root's TVirtualFFT interface. The simple solution is to go through and replace the variable length arrays with std::vector's, then pass the underlying array to the routine. On the other hand, maybe a better solution is to replace TVirtualFFT with something better. Is there a "better" package available in larsoft which provides an FFT interface?