Milestone #15086: Onboard ICARUS
Introduce a proper view to describe ICARUS wire planes
ICARUS wire orientation on the planes include wires parallel to z axis, which according to the current convention would be labelled as view "X".
ICARUS needs such a labelling be made available.
#1 Updated by Gianluca Petrillo almost 4 years ago
- Status changed from New to Assigned
- Assignee set to Wesley Ketchum
- % Done changed from 0 to 40
Erica Snider, Wesley Ketchum and Gianluca Petrillo (and also Tracy Usher) have carried on a discussion on how to provide the requested feature.
While the complete solution is desirable, it will have a relevant impact on LArSoft code base and it requires some very careful design.
For the "onboarding" phase, LArSoft has agreed to start with a shortcut, which is to add a new view label
Some code still needs to be adapted, mostly because in LArSoft code base the concepts of plane number, signal type and view have been promiscuously used.
#5 Updated by Tracy Usher almost 4 years ago
Just a comment... the wires in question run parallel to the Z axis and "measure" in the Y direction. Hence they should be labeled as "Y" wires, not "X" wires. Refer to, for example, MicroBooNE where the collection plan wires are parallel to the Y axis and measure in the Z direction and not the (unused) geo_types definition of "kZ" for those wires.
#6 Updated by Gianluca Petrillo over 3 years ago
- Status changed from Work in progress to Resolved
- % Done changed from 80 to 100
Support for views named
kY is present at least since commit larcore:71c9c478595414631f2ee5d6ac504dcc323edb39 .
The code in
geo::PlaneGeo automatically assigns the view label according to the wire orientation, and more specifically according to the coordinate the plane measures, as Tracy points out.
That translates in
kY for the horizontal ICARUS wires and
kX for the longitudinal DUNE DualPhase wires.