Please add a fhicl::Comment(std::string) constructor
Concatenating the comment from strings, like in
currently requires to go through a
fhicl::Comment("Atomic numbers; allowed values are " + std::to_string(Z_xenon) + " and " + std::to_string(Z_argon) + ".")
c_str()call, and makes the user (me) wonder if the destruction of the temporary string will cause havoc.
(I eventually read the code: it doesn't)
Comment(std::string)constructor moving the string into the comment object would be welcome.
#2 Updated by Kyle Knoepfel almost 3 years ago
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
Somewhat non-trivial to implement due to overload ambiguities, but it was achieved through a layer of indirection, which is invisible to the user.
Implemented with commit fhicl-cpp:2711923.