Necessary Maintenance #15446
BezierTrack should be removed from LArSoft
Description
The class BezierTrack
has been deprecated since long time, and it was never well supported.
The LArSoft coordination meeting on January 31, 2017 has agreed to get rid of it.
This will include the data product itself and the modules which produce it, in addition to chopping away parts of other analysers that optionally support it.
If a class similar is ever needed, we'll use a new design.
Related issues
Associated revisions
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
Updates for issue #15446 (Bezier tracking)
History
#1 Updated by Lynn Garren almost 4 years ago
- Status changed from New to Accepted
This will be coupled to recob::Track stage 2.
#2 Updated by Lynn Garren almost 4 years ago
- Related to Task #14281: Provide an interface for access of reconstructed track information added
#3 Updated by Katherine Lato over 3 years ago
- Target version set to 2017-4-quarter
#4 Updated by Gianluca Petrillo about 3 years ago
- Assignee set to Gianluca Petrillo
#5 Updated by Gianluca Petrillo about 3 years ago
- Status changed from Accepted to Feedback
- % Done changed from 0 to 10
Its removal dragged into oblivion:
- event display feature of interactive creation of seeds (
MakeSeeds
) - probably some other minor feature of the event display
- optical detector related modules:
BeamFlashCompatibilityCheck
,FlashPurityCheckAna
,TrackTimeAssoc
andTrackTimeAssocAna
- tracking module
FeatureTracker
- some calorimetry features
Numerous experiment job configuration files had to be cleaned, presumably outdated ones. In addition, DUNE 35t unit tests became broken because of the use of some of the modules that have been chopped away. I haven't even tried to execute the integration tests.
It should be pointed out that the code that has been removed has been, to my knowledge, unmaintained for long time.
This intervention has been carried out using a sledgehammer. Maybe a different, bistoury-based, approach is possible.
#6 Updated by Gianluca Petrillo about 3 years ago
- Status changed from Feedback to Resolved
- % Done changed from 10 to 100
I have taken a different, softer approach, and introduced some design. The proposed solution is in branch feature/gp_Issue15446_light
of the LArSoft repositories lardataobj
, larreco
and larana
, and the experiment code uboonecode
, dunetpc
and icaruscode
.
The deprecated object trk::BezierTrack
(larreco:source:larreco/Deprecated/BezierTrack.h) does not inherit from recob::Track
any more, but it contains a recob::Trajectory
data member. It can be initialised from a recob::Track
(or recob::Trajectory
plus a numeric ID), but it can't be turned into a recob::Track
(it can be turned into a recob::Trajectory
in the sense that the internal trajectory can be retrieved; the ID information is not carried on).
- the few times user code called
recob::Track
inherited interface have been corrected to call the trajectory equivalent - the
BezierTrackerModule
producer that used to producerecob::Track
producesrecob::Trajectory
instead
Most important, recob::Track
, recob::TrackTrajectory
and recob::Trajectory
are now completely independent (and not friend) of trk::BezierTrack
.
#7 Updated by Gianluca Petrillo almost 3 years ago
- Status changed from Resolved to Closed
Updates for issue #15446 (Bezier tracking)