Necessary Maintenance #15446
BezierTrack should be removed from LArSoft
BezierTrack has been deprecated since long time, and it was never well supported.
The LArSoft coordination meeting on January 31, 2017 has agreed to get rid of it.
This will include the data product itself and the modules which produce it, in addition to chopping away parts of other analysers that optionally support it.
If a class similar is ever needed, we'll use a new design.
#5 Updated by Gianluca Petrillo almost 3 years ago
- Status changed from Accepted to Feedback
- % Done changed from 0 to 10
Its removal dragged into oblivion:
- event display feature of interactive creation of seeds (
- probably some other minor feature of the event display
- optical detector related modules:
- tracking module
- some calorimetry features
Numerous experiment job configuration files had to be cleaned, presumably outdated ones. In addition, DUNE 35t unit tests became broken because of the use of some of the modules that have been chopped away. I haven't even tried to execute the integration tests.
It should be pointed out that the code that has been removed has been, to my knowledge, unmaintained for long time.
This intervention has been carried out using a sledgehammer. Maybe a different, bistoury-based, approach is possible.
#6 Updated by Gianluca Petrillo almost 3 years ago
- Status changed from Feedback to Resolved
- % Done changed from 10 to 100
I have taken a different, softer approach, and introduced some design. The proposed solution is in branch
feature/gp_Issue15446_light of the LArSoft repositories
larana, and the experiment code
The deprecated object
trk::BezierTrack (larreco:source:larreco/Deprecated/BezierTrack.h) does not inherit from
recob::Track any more, but it contains a
recob::Trajectory data member. It can be initialised from a
recob::Trajectory plus a numeric ID), but it can't be turned into a
recob::Track (it can be turned into a
recob::Trajectory in the sense that the internal trajectory can be retrieved; the ID information is not carried on).
- the few times user code called
recob::Trackinherited interface have been corrected to call the trajectory equivalent
BezierTrackerModuleproducer that used to produce
recob::Trajectory are now completely independent (and not friend) of