LArSoft

This will be coupled to recob::Track stage 2.

• event display feature of interactive creation of seeds (MakeSeeds)
• probably some other minor feature of the event display
• optical detector related modules: BeamFlashCompatibilityCheck, FlashPurityCheckAna, TrackTimeAssoc and TrackTimeAssocAna
• tracking module FeatureTracker
• some calorimetry features

Numerous experiment job configuration files had to be cleaned, presumably outdated ones. In addition, DUNE 35t unit tests became broken because of the use of some of the modules that have been chopped away. I haven't even tried to execute the integration tests.

It should be pointed out that the code that has been removed has been, to my knowledge, unmaintained for long time.

This intervention has been carried out using a sledgehammer. Maybe a different, bistoury-based, approach is possible.

I have taken a different, softer approach, and introduced some design. The proposed solution is in branch feature/gp_Issue15446_light of the LArSoft repositories lardataobj, larreco and larana, and the experiment code uboonecode, dunetpc and icaruscode.

The deprecated object trk::BezierTrack (larreco:source:larreco/Deprecated/BezierTrack.h) does not inherit from recob::Track any more, but it contains a recob::Trajectory data member. It can be initialised from a recob::Track (or recob::Trajectory plus a numeric ID), but it can't be turned into a recob::Track (it can be turned into a recob::Trajectory in the sense that the internal trajectory can be retrieved; the ID information is not carried on).

• the few times user code called recob::Track inherited interface have been corrected to call the trajectory equivalent
• the BezierTrackerModule producer that used to produce recob::Track produces recob::Trajectory instead

Most important, recob::Track, recob::TrackTrajectory and recob::Trajectory are now completely independent (and not friend) of trk::BezierTrack.