Project

General

Profile

Necessary Maintenance #15289

Pointless __GCCXML__ in LArSoft data products

Added by Gianluca Petrillo over 2 years ago. Updated over 1 year ago.

Status:
Accepted
Priority:
Low
Assignee:
-
Category:
Data products
Target version:
Start date:
01/24/2017
Due date:
% Done:

0%

Estimated time:
Experiment:
-
Duration:

Description

Data products in LArSoft used to hide part of the code from ROOT 5 by enclosing it in #ifndef __GCCXML__ guards. This was necessary due to the... limitations of CINT and friends.
ROOT 6 is using rootcling instead, whose level of understanding is basically the same as gcc. Those guards are therefore not needed. But, more to the point, rootcling does not define __GCCXML__ any more, so those guards are ineffective and misleading.
LArSoft should consider removing them or replacing them with __ROOTCLING__ guards, which are the equivalent in the new world.

To be more explicit: that they are not needed is proven by the fact that they have been ignored since LArSoft 6.0.1, and nobody has reported any related problem since.

History

#1 Updated by Erica Snider over 2 years ago

  • Status changed from New to Accepted
  • Target version set to 2017-1-quarter

#2 Updated by Katherine Lato over 2 years ago

  • Target version changed from 2017-1-quarter to 2017-4-quarter

#3 Updated by Katherine Lato over 1 year ago

  • Target version changed from 2017-4-quarter to 2019-1-quarter


Also available in: Atom PDF