Feature #15099

Add reco option to fix pedestals in 35t processing

Added by David Adams almost 4 years ago. Updated almost 4 years ago.

Start date:
Due date:
% Done:


Estimated time:


As discussed in my talk in today's 35t sim/reco meeting (, there are cases where the pedestals used in 35t processing are not very good. We should add the option to calculate these during dataprep, the first stage in reconstruction, in particular before correlated noise removal.


#1 Updated by David Adams almost 4 years ago

Dataprep provides the option to calculate an apply a pedestal after deconvolution. This is too late for noise removal and so we should add another opportunity for this. It is natural to do this in the TPC data extraction service (StandardRawDigitExtractService) where the first pedestal subtraction is performed. At present, it offers two options: 1) to use the pedestal recorded with the data and 2) to obtain the pedestal from the pedestal provider which is connected to the 35t pedestal database.

My analysis software makes use of the extraction service and both it and standard reco (standard_reco_dune35tdata.fcl) use the first option. Karl, can you confirm that this is the fcl we use for 35t production reconstruction?

I will modify StandardRawDigitExtractService to add the option to calculate the pedestal from the event data.

#2 Updated by Thomas Warburton almost 4 years ago

Hi David,

Yes, I believe that that is the standard reconstruction option.


#3 Updated by David Adams almost 4 years ago

I have made the following modifications.

The interface RawDigitExtractService.h is modified to take an AdcChannelData object instead of its constituents.

StandardRawDigitPrepService is updated to use the new interface.

StandardRawDigitExtractService is modified to the new interface and to add pedestal option 3 to use PedestalEvaluationService to evaluate the pedestal from the data.

MedianPedestalService is modified to add the option to calculate the pedestal from the mean instead of median.

dataprep_dune.fcl is modified to add UseMean = false to adcped_median and to add adcped_mean with this set to true.

I have verified that all tests pass and that my analysis job gets the expected results with the new code.

#4 Updated by David Adams almost 4 years ago

The above is committed to dunetpc with tag 10134a4419fb29fa00a6fe8c6016eba5759fe49c. Note that there should be no change in the output of default processing.

#5 Updated by David Adams almost 4 years ago

  • Status changed from Assigned to Closed

I have dropped the old and now-obsolete code from StandardRawDigitExtractService.

New tag is c2b3a512f076edeb49ba6e0ee6812b45f35c8a25.

Changes pushed to dunetpc.

I close this report.

Also available in: Atom PDF