Project

General

Profile

Bug #15084

Extra "fi" keyword in condor_startup code

Added by Marco Mambelli almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
01/11/2017
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

In condor_startup there is an unbalanced conditional statement, a "fi" keyword without matching "if".
Indentation was also confusing at times, I fixed it.

History

#1 Updated by Marco Mambelli almost 4 years ago

  • Status changed from New to Feedback
  • Assignee changed from Marco Mambelli to Parag Mhashilkar

Changes are in v3/15084
I cleaned a bit the code, mostly making sure that all statements in a block have the the same level of indentation. This is not necessary in bash but helps readability.

#2 Updated by Marco Mambelli almost 4 years ago

There was actually no extra "fi", only the indentation was confusing.
Thanks to Parag feedback I checked better the code and corrected the indentation

#3 Updated by Parag Mhashilkar almost 4 years ago

  • Assignee changed from Parag Mhashilkar to Marco Mambelli
  • Target version changed from v3_2_18 to v3_2_19

Looks ok to merge, but I would not put it in 3.2.18 to avoid any other potential issues.

#4 Updated by Marco Mambelli over 3 years ago

  • Status changed from Feedback to Resolved

#5 Updated by Parag Mhashilkar over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF