Project

General

Profile

Bug #15074

unnecessary loop, possible problem in glideFactoryLib.py::submitGlideins

Added by Dennis Box almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
01/10/2017
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

in submitGlideins the flow of control is

while (nr_submitted < nr_glideins):
#a little later
for var in os.environ:
#append a bunch of env variables to an array

We discovered in #14474 that this type of appending could have harmful side effects. At the least there is unnecessary work going on, the for var: loop only needs to be run once.

History

#1 Updated by Marco Mambelli almost 4 years ago

  • Target version changed from v3_2_18 to v3_2_19

#2 Updated by Dennis Box over 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Dennis Box to Marco Mambelli

#3 Updated by Marco Mambelli over 3 years ago

  • Assignee changed from Marco Mambelli to Dennis Box

OK to merge

#4 Updated by Dennis Box over 3 years ago

  • Status changed from Feedback to Resolved

merged to branch_v3_2

#5 Updated by Parag Mhashilkar over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF