Bug #14365: Plane geometry object hosts readout information - LArSoft - Fermilab Redmine

Bug #14365

Plane geometry object hosts readout information

Added by Gianluca Petrillo almost 3 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Gianluca Petrillo

Category:

Geometry

Target version:

2017-1-quarter

Start date:

11/02/2016

Due date:

11/07/2016

% Done:

100%

Estimated time:

Spent time:

4.00 h

Occurs In:

Experiment:

Co-Assignees:

Duration: 6

Description

The class geo::PlaneGeo is initialised from the geometry description (GDML), and it is meant to report geometry information on a wire plane.
Unfortunately some readout information slipped in: the signal type (fSignalType and methods).
Since this object and its relatives do not know anything about signal types, the assignment of a signal type is performed by the parent geo::TPCGeo by a guess: geo::kCollection if it is the last plane in the TPC, geo::kInduction otherwise.
This logic reflects the situation in the wire-based TPCs, but miserably fails for other types of readout (namely, dual phase where there are two collection strip planes).

This information from geo::PlaneGeo is used by geo::GeometryCore::SignalType(geo::PlaneID) to provide the signal type on a specified plane.
All code using it, or directly using geo::PlaneGeo::SignalType(), is broken with respect to these alternative detectors.
Note that queries of signal type from channel ID do not use this information, but rather forward the query to the ChannelMapAlg algorithm.

I propose the removal of this redundant and ill-designed information from geo::PlaneGeo.

Related issues

Associated revisions

Revision d66d0e92 (diff)
Added by Gianluca Petrillo almost 3 years ago

Deprecated geo::PlaneGeo::SignalType() .

This is toward the resolution of issue #14365 .
Also geo::PlaneGeo::SetSignalType() is to be considered deprecated, but it's not marked so because it is still necessary to maintain the legacy, deprecated functionality.
Instead, it's being made private (it's not supposed to be used except than for post-processing during geometry initialisation).

Revision f0dbb8ca (diff)
Added by Gianluca Petrillo almost 3 years ago

Deprecated geo::PlaneGeo::SignalType() .

Revision 7b229a6c (diff)
Added by Gianluca Petrillo almost 3 years ago

Deprecating geo::PlaneGeo::SignalType().

This pertains issue #14365 .

Revision a43c199d (diff)
Added by Gianluca Petrillo almost 3 years ago

Deprecating geo::PlaneGeo::SignalType().

This pertains issue #14365 .

Revision a83cb097 (diff)
Added by Gianluca Petrillo over 2 years ago

Removed geo::PlaneGeo::SignalType() and geo::PlaneGeo::SetSignalType()

This solves issue #14704 (follow up of issue #14365).

Revision d4fcac31 (diff)
Added by Gianluca Petrillo over 2 years ago

Removed geo::PlaneGeo::SignalType() and geo::PlaneGeo::SetSignalType()

This solves issue #14704 (follow up of issue #14365).

History

#1 Updated by Gianluca Petrillo almost 3 years ago

Blocks Feature #14364: Build a geometry infrastructure for support of arbitrary drift direction added

#2 Updated by Lynn Garren almost 3 years ago

Status changed from New to Assigned
Assignee set to Gianluca Petrillo
Target version set to 2017-1-quarter

Gianluca will propose this at the coordination meeting.

#3 Updated by Gianluca Petrillo almost 3 years ago

% Done changed from 0 to 80

Changes were approved at LArSoft coordination meeting on November 8th, 2016 .

#4 Updated by Gianluca Petrillo almost 3 years ago

Non-breaking changes have been pushed into develop for the repositories: larcore, larevt, lareventdisplay, larreco and dunetpc.

Wherever geo::PlaneGeo::SygnalType() was used, now geo::GeometryCore::SignalType() provides that information.
This commit also includes the introduction of geo::PlaneGeo::ID(), geo::TPCGeo::ID() and geo::CryostatGeo::ID() to facilitate this migration and as a new feature.