Project

General

Profile

Feature #14128

Fermilab security asked to update to the latest jQuery (1.12)

Added by Marco Mambelli about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
10/10/2016
Due date:
% Done:

0%

Estimated time:
Stakeholders:
Duration:

Description

jQuery is a library used by some of the frontend and factory monitoring pages

Frontend:
creation/web_base/frontendGroupGraphStatusNow.html
(imports jquery-ui.css 1.8 , jquery.min.js 1.8.3 and jquery-ui.min.js 1.9.2

Factory:
monitor/jslibs/javascriptrrd.wlibs.js (includes the code of jquery 1.5.1)

javascriptrrd.wlibs.js (157 KB) javascriptrrd.wlibs.js Marco Mambelli, 10/25/2016 06:17 PM

History

#1 Updated by Marco Mambelli about 4 years ago

Some links:
http://www.flotcharts.org/
http://javascriptrrd.sourceforge.net/
https://code.jquery.com/
https://code.jquery.com/jquery/ (all versions)

Some ideas:
- update (and test) to the latest flot and javascriptRRD
- update to the latest jQuery and test that all is OK
- consider an alternative technology for the long run

#2 Updated by Marco Mambelli about 4 years ago

  • Target version changed from v3_2_x to v3_2_17

#3 Updated by Marco Mambelli about 4 years ago

  • Assignee set to Dennis Box

#4 Updated by Marco Mambelli about 4 years ago

Changes are in v3/14128
Changes require also a javascriptrrd.wlib.js version that has no jQuery and Sizzle embedded (like the one attached).

There are still errors because of missing imports. Files seem not used but the import statements are still there.
Multiple files have it here is factoryStatus.html:
factoryStatus.html:19 GET http://fermicloud364.fnal.gov/factory/monitor/jslibs/binaryXHR.js
factoryStatus.html:20 GET http://fermicloud364.fnal.gov/factory/monitor/jslibs/rrdFile.js
factoryStatus.html:21 GET http://fermicloud364.fnal.gov/factory/monitor/jslibs/rrdMultiFile.js
factoryStatus.html:22 GET http://fermicloud364.fnal.gov/factory/monitor/jslibs/rrdFilter.js

Basic tests seem all to wrk fine, please test further. Thanks

#5 Updated by Marco Mambelli about 4 years ago

  • Status changed from New to Feedback
  • Assignee changed from Marco Mambelli to Parag Mhashilkar

#6 Updated by Parag Mhashilkar about 4 years ago

  • Assignee changed from Parag Mhashilkar to Marco Mambelli

changes look ok to merge

#7 Updated by Marco Mambelli about 4 years ago

  • Status changed from Feedback to Resolved

libraries like binaryXHR.js, rrdFile.js, rrdMultiFile.js and rrdFilter.js were imported from "jslibs/" but were never installed there.
Looking at the code it seems that the functions used from those libraries have actually been pasted in jslibs/javascriptrrd.wlibs.js so there is no need to import these libraries.
We discussed about removing the imports and check the pages.
After removing the import statements there are no more errors in the javascript console and the plots seem to work as usual.
So I'm committing the change and merging it with the rest to branch_v3_2.

#8 Updated by Parag Mhashilkar almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF