Project

General

Profile

Bug #13718

MCRecoPart uses non-portable coordinate system

Added by Gianluca Petrillo about 3 years ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Simulation
Target version:
-
Start date:
08/30/2016
Due date:
% Done:

0%

Estimated time:
Occurs In:
Experiment:
LArSoft, MicroBooNE
Co-Assignees:
Duration:

Description

sim::MCRecoPart uses the TPC volume to define whether a trajectory point is within or without the TPC.
It hard-codes assumptions on the coordinate system and it's not compatible with multi-TPC environment.
It also does not exactly match the TPC coordinates of MicroBooNE geometry, which are used by Geant4 and as a consequence by the simb::MCParticle with its trajectory points.

The code is at: larsim:source:larsim/MCSTReco/MCRecoPart.cxx#L26 .


Related issues

Related to LArSoft - Bug #21394: Bug in Fiducial Volume Definition in LarsimResolved11/17/2018

History

#1 Updated by Katherine Lato about 3 years ago

  • Status changed from New to Feedback

Gianluca will talk with the author.

#2 Updated by Gianluca Petrillo almost 3 years ago

The author declined to make the needed changes.
We have two options:

  1. ship this code back to uboonecode until the usefulness of this code is reclaimed by other experiments
  2. fix the limitations, recover or write the documentation, and test it on MicroBooNE and on other detectors to validate the changes (first guess is 20 hours work)

#3 Updated by Katherine Lato over 2 years ago

The limitations are too big for us to address and the author of the code has declined to fix it.

It appears no other experiment uses the code, so the next step is to remove this from LArSoft.

#4 Updated by Katherine Lato over 2 years ago

  • Status changed from Feedback to Assigned
  • Assignee set to Saba Sehrish

Assigning to Saba who will remove the code after finishing other tasks.

#5 Updated by Gianluca Petrillo 11 months ago

  • Related to Bug #21394: Bug in Fiducial Volume Definition in Larsim added

#6 Updated by Saba Sehrish 7 months ago

  • Status changed from Assigned to Resolved


Also available in: Atom PDF