Project

General

Profile

Bug #13513

Broken FHiCL configuration (was: Bo configuration broken)

Added by Gianluca Petrillo almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Gianluca Petrillo
Category:
Other
Target version:
-
Start date:
08/11/2016
Due date:
% Done:

100%

Estimated time:
1.00 h
Spent time:
2.50 h
Occurs In:
v06_03_00
Experiment:
LArSoft
Co-Assignees:
Duration:

Description

Some job configuration files (reconstruction, event display) are stored in LArSoft.
They require a service configuration table from a file, services_bo.fcl that is nowhere to be found.

Missing file should be recreated, or the depending configuration files removed.

Associated revisions

Revision 126ea911 (diff)
Added by Gianluca Petrillo almost 4 years ago

Removed obsolete configuration files (issue #13513)

Revision ef23ebc4 (diff)
Added by Gianluca Petrillo almost 4 years ago

Removed obsolete configuration files (issue #13513)

Revision 3027da5c (diff)
Added by Gianluca Petrillo almost 4 years ago

Removed obsolete configuration files (issue #13513)

Revision a05e648c (diff)
Added by Gianluca Petrillo almost 4 years ago

Removed obsolete configuration files (issue #13513)

Revision c97a8e3c (diff)
Added by Gianluca Petrillo almost 4 years ago

Removed obsolete configuration files (issue #13513)

History

#1 Updated by Lynn Garren almost 4 years ago

I had the impression that the b0 configuration was obsolete?

#2 Updated by Gianluca Petrillo almost 4 years ago

  • Subject changed from Bo configuration broken to Broken FHiCL configuration (was: Bo configuration broken)

Job configurations larevt/CalData/test/simwire_argoneut.fcl, larevt/CalData/test/ffttest_argoneut.fcl and larevt/Filters/mufilter.fcl are also broken (require services.fcl).

#3 Updated by Gianluca Petrillo almost 4 years ago

Same for: larsim/larsim/EventGenerator/csu40L_fulloptical.fcl, larsim/larsim/EventGenerator/csu40L_buildopticallibrary.fcl and larsim/larsim/EventGenerator/csu40L_fastoptical.fcl which again refer to the non-existing services.fcl.

This concludes my survey.
If the file services.fcl could be resurrected, it would solve these CSU40l and ArgoNeuT problems.
Otherwise, my recommendation is to deleted the configuration, since it's hard to maintain and at the same time unusable.

#4 Updated by Lynn Garren almost 4 years ago

Once the original repository is located, use "git log -- <file name>"

git log --full-history -- Utilities/services.fcl
commit 7f9bd2d64858ac71c7ccb495673b184ca02f5e85
Author: Tingjun Yang <tjyang@uboonegpvm04.fnal.gov>
Date:   Thu Aug 14 11:51:06 2014 -0500

    clean up fcl files


git log --full-history -- Utilities/services_bo.fcl
commit aade8c1f7f465f0f5d52cbf90e64b747f3498833
Author: Gianluca Petrillo <petrillo@fnal.gov>
Date:   Thu Feb 26 16:58:19 2015 -0600

    SeedService stuff moved away (temporary exception for ArgoNeuT)

It is clear that these files were intentionally removed. The old fcl files which use services.fcl and services_bo.fcl should also be removed.

#5 Updated by Gianluca Petrillo almost 4 years ago

Tingjun, do you confirm that ArgoNeut does not use the FHiCL files mentioned above: larevt/CalData/test/simwire_argoneut.fcl, larevt/CalData/test/ffttest_argoneut.fcl and larevt/Filters/mufilter.fcl, and that they can be removed?

I don't see any service.fcl in argoneutcode either, so I am assuming that file was removed rather than moved, and that nobody could be using the files above.

#6 Updated by Tingjun Yang almost 4 years ago

Hi Gianluca,

I confirm those files should be deleted.

Tingjun
Gianluca Petrillo wrote:

Tingjun, do you confirm that ArgoNeut does not use the FHiCL files mentioned above: larevt/CalData/test/simwire_argoneut.fcl, larevt/CalData/test/ffttest_argoneut.fcl and larevt/Filters/mufilter.fcl, and that they can be removed?

I don't see any service.fcl in argoneutcode either, so I am assuming that file was removed rather than moved, and that nobody could be using the files above.

#7 Updated by Gianluca Petrillo almost 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Gianluca Petrillo
  • % Done changed from 0 to 100
  • Experiment LArSoft added
  • Experiment deleted (-)

The following files will be removed:

  • from lardata: lardata/Utilities/standard_reco_bo.fcl and lardata/Utilities/bo_reco.fcl
  • from larevt: larevt/CalData/test/simwire_argoneut.fcl, larevt/CalData/test/ffttest_argoneut.fcl and larevt/Filters/mufilter.fcl
  • from larsim: larsim/EventGenerator/csu40L_fulloptical.fcl, larsim/EventGenerator/csu40L_buildopticallibrary.fcl and larsim/EventGenerator/csu40L_fastoptical.fcl
  • from lareventdisplay: lareventdisplay/EventDisplay/evdservices_bo.fcl and lareventdisplay/EventDisplay/evd_bo.fcl

#8 Updated by Gianluca Petrillo almost 4 years ago

  • Status changed from Assigned to Resolved

Changes have been pushed.

#9 Updated by Gianluca Petrillo almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF