Bug #12978
GausHitFinder requires algorithm configuration even when it does not use it
Occurs In:
Experiment:
LArSoft
Co-Assignees:
Description
A recent change to GausHitFinder introduces an optional hit filtering algorithm.
Unfortunately, the module requires the configuration of the algorithm even if the algorithm itself is not run (which is in fact the default behaviour):
- this is a breaking change, since existing configurations have to add the filter algorithm configuration, whether they want to use it or not
- it makes no sense to have to specify a (even dummy) configuration for something that is explicitly not used
The fix is easy: just provide a default value for that configuration parameter and do not instantiate the algorithm unless it's required.
Related issues
History
#1 Updated by Gianluca Petrillo almost 5 years ago
- Blocks Bug #12979: Bug upstream on GausHitFinder module requires a temporary fix in SBND configuration added
#2 Updated by Gianluca Petrillo almost 5 years ago
Fix was pushed in larreco branch feature/gp_GausHitFilterMadeOptional (larreco:eab7c2f944d161772d34a9d518f1717ac58c1838).
Expected to be merged in the coming LArSoft release.
#3 Updated by Gianluca Petrillo almost 5 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
#4 Updated by Katherine Lato almost 5 years ago
- Assignee set to Gianluca Petrillo
Resolved, but still unassigned, so assigning it to Gianluca just to clear up the database.
#5 Updated by Gianluca Petrillo almost 5 years ago
- Status changed from Resolved to Closed