Project

General

Profile

Bug #12897

a bug in the new feature frontend downtime

Added by HyunWoo Kim over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
06/09/2016
Due date:
% Done:

0%

Estimated time:
First Occurred:
Occurs In:
Stakeholders:
Duration:

Description

While translating /etc/init.d/gwms-frontend in the local instance into
creation/templates/frontend_initd_startup_template,
a bug was introduced.
(FRONTEND_DOWNTIMES is not initialized)
This can be easily fixed.

Another issue is, the documentation for this new feature was put in install.html
just as Factory.
doc/frontend/configuration.html will be also updated to introduce this new feature.

History

#1 Updated by HyunWoo Kim over 3 years ago

  • Status changed from New to Assigned

Here is what I did about this issue:

- created a new branch v3/12897
- modified two files
glideinwms/creation/templates/frontend_initd_startup_template
glideinwms/doc/frontend/configuration.html

- testing was a bit tricky because frontend_initd_startup_template will be translated to /etc/init.d/gwms-frontend when rpm is build.
So, I did diff command between this template file and my local file that is working
and modified manually the template.
This manual modifications were

[hyunwoo@hepcloud-devfe templates]$ diff frontend_initd_startup_template  /etc/init.d/gwms-frontend
56,59c56,59
< frontend_dir=%(frontend_dir)s
< glideinWMS_dir=%(glideinWMS_dir)s
< def_frontend_config=%(default_cfg_fpath)s
< RPM_INSTALL=%(rpm_install)s
---
> frontend_dir=/var/lib/gwms-frontend/vofrontend
> glideinWMS_dir=/var/lib/gwms-frontend/vofrontend
> def_frontend_config=/etc/gwms-frontend/frontend.xml
> RPM_INSTALL=True

167,168c167,168
< # Double percent %% needed for template substitution
< FILE_OWNER=`stat -c%%u "$def_frontend_config"`
---
> # Double percent % needed for template substitution
> FILE_OWNER=`stat -c%u "$def_frontend_config"`

Then I put this modified template under /etc/init.d/ after saving the existing gwms-frontend
and then conducted the testing of various donwtime features as shown in install.html

#2 Updated by Parag Mhashilkar over 3 years ago

  • Target version set to v3_2_15

#3 Updated by HyunWoo Kim over 3 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from HyunWoo Kim to Marco Mambelli

(The original issue was 3422 which was pushed to 3_2_14 but a bug was found).
The bug that is corrected is in
glideinwms/creation/templates/frontend_initd_startup_template

I also updated the following HTML files
glideinwms/doc/frontend/configuration.html
glideinwms/doc/frontend/install.html

To be consistent with the instruction in configuration.html, I also corrected a couple of typos in print messages in
glideinwms/frontend/manageFrontendDowntimes.py

#4 Updated by Marco Mambelli over 3 years ago

  • Assignee changed from Marco Mambelli to HyunWoo Kim

Changes look OK. OK to merge

#5 Updated by HyunWoo Kim over 3 years ago

  • Status changed from Feedback to Closed

Merged.



Also available in: Atom PDF