Project

General

Profile

Necessary Maintenance #12367

Merge namespaces lar::utils and lar::util

Added by Gianluca Petrillo over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Low
Category:
Other
Target version:
-
Start date:
04/19/2016
Due date:
% Done:

100%

Estimated time:
2.00 h
Spent time:
Experiment:
LArSoft
Duration:

Associated revisions

Revision 3b68a107 (diff)
Added by Gianluca Petrillo about 4 years ago

Replaced nsmaepace lar::utils with lar::util (issue #12367)

Revision 677e2144 (diff)
Added by Gianluca Petrillo about 4 years ago

Replaced nsmaepace lar::utils with lar::util (issue #12367)

Revision a858d37f (diff)
Added by Gianluca Petrillo about 4 years ago

Replaced nsmaepace lar::utils with lar::util (issue #12367)

Revision 47f95301 (diff)
Added by Gianluca Petrillo about 4 years ago

Replaced nsmaepace lar::utils with lar::util (issue #12367)

Revision 0450ba49 (diff)
Added by Gianluca Petrillo about 4 years ago

Replaced nsmaepace lar::utils with lar::util (issue #12367)

Revision 4410d38e (diff)
Added by Gianluca Petrillo almost 4 years ago

Replaced nsmaepace lar::utils with lar::util (issue #12367)

Revision 43a361eb (diff)
Added by Gianluca Petrillo almost 4 years ago

Replaced lar::utils namespace with lar::util .

This is related to issue #12367. This instance was either missed or ignored on the previous survey.

Revision 5804d75a (diff)
Added by Gianluca Petrillo almost 4 years ago

Removed lar::utils namespace

This completes the solution of issue #12367 .

History

#1 Updated by Gianluca Petrillo over 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Gianluca Petrillo
  • Priority changed from Normal to Low
  • Estimated time set to 2.00 h

It will be a breaking change.

#2 Updated by Gianluca Petrillo about 4 years ago

  • % Done changed from 0 to 80

I have moved the functions from lar::utils into lar::util.

For this first phase, lar::utils namespace still exists, with functions and types which are aliases of the ones now in lar::util. These "alias" functions are deprecated and using them will have the compiler emit a deprecation warning:

warning: ‘auto lar::utils::TrackPitchInView(const recob::Track&, geo::View_t, size_t)’ is deprecated (declared at [...]/srcs/lardata/lardata/RecoBaseArt/TrackUtils.h:66): use lar::util namespace instead [-Wdeprecated-declarations]

These functions will be removed after a grace period.
Branches feature/gp_Issue12367 have been published for the LArSoft repositories lardataobj, lardata, larsim, larreco, larana; and for the experiment repositories argoneutcode, dunetpc and lariatsoft.
Using these branches, no deprecation warnings about lar::utils should be emitted.

#3 Updated by Gianluca Petrillo about 4 years ago

This issue should be revisited in three weeks (August 25, 2016) to consider the removal of the deprecated code.

#4 Updated by Gianluca Petrillo almost 4 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 80 to 100

Removal of the deprecated namespace was accepted at LArSoft coordination meeting on November 8, 2016 .

Residual changes have been pushed to develop branches of argoneutcode, larsim and lardataobj (the latter two only cosmetic).

The branch feature/gp_Issue12367 of lardata contains the final removal, which is scheduled for integration on the next LArSoft release.

#5 Updated by Gianluca Petrillo almost 4 years ago

  • Status changed from Resolved to Closed

The code was integrated in LArSoft 6.14.0 .



Also available in: Atom PDF