Project

General

Profile

Feature #11949

Adjust art summary to report more helpful numbers for analyzers and output modules

Added by Kyle Knoepfel almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Infrastructure
Target version:
Start date:
03/14/2016
Due date:
% Done:

100%

Estimated time:
16.00 h
Spent time:
Scope:
Internal
Experiment:
-
SSI Package:
art
Duration:

Description

Consider a job configuration where a filter path p1 accepts 310 out of 1000 events. Suppose that an analyzer module a1 is configured with a SelectEvents: { SelectEvents: [p1] } clause. The current summary printout will look like (snipped):

TrigReport ---------- Path   Summary ------------
TrigReport  Trig Bit#        Run     Passed     Failed      Error Name
TrigReport     1    0       1000        310        690          0 p1

TrigReport -------End-Path   Summary ------------
TrigReport  Trig Bit#        Run     Passed     Failed      Error Name
TrigReport     0    0       1000       1000          0          0 end_path

TrigReport ------ Modules in End-Path: end_path ------------
TrigReport  Trig Bit#    Visited     Passed     Failed      Error Name
TrigReport     0    0       1000       1000          0          0 a1

Here, 'Visited' refers to the number of times the worker processed an event, and not the number events the module actually saw. In addition, since analyzers and output modules do not filter events, the 'Passed' and 'Failed' columns are inappropriate.

As discussed at the stakeholders meeting last week (3/10/16), the summary printout for analyzers and output modules should be adjusted to:

TrigReport ---------- Path   Summary ------------
TrigReport  Trig Bit#        Run     Passed     Failed      Error Name
TrigReport     1    0       1000        310        690          0 p1

TrigReport -------End-Path   Summary ------------
TrigReport  Trig Bit#        Run    Success      Error Name
TrigReport     0    0       1000       1000          0 end_path

TrigReport ------ Modules in End-Path: end_path ------------
TrigReport  Trig Bit#        Run    Success      Error Name
TrigReport     0    0        310        310          0 a1

In this case, the 'Visited' column would correspond to the event count that a user would obtain by putting their own counter in their module (without them having to do it).

History

#1 Updated by Kyle Knoepfel almost 4 years ago

  • Description updated (diff)

#2 Updated by Kyle Knoepfel almost 4 years ago

  • Status changed from New to Accepted

#3 Updated by Kyle Knoepfel almost 4 years ago

  • Estimated time set to 16.00 h

#4 Updated by Kyle Knoepfel over 3 years ago

  • Status changed from Accepted to Assigned
  • Assignee set to Kyle Knoepfel

#5 Updated by Kyle Knoepfel over 3 years ago

  • Category set to Infrastructure
  • Status changed from Assigned to Resolved
  • Target version set to 2.05.00
  • % Done changed from 0 to 100

Implementing this feature was more involved than originally anticipated. It required propagating the counters all the way down to the module base classes. Tackling this problem, though, afforded the opportunity to clean up some of the event-loop infrastructure.

Implemented with the following art commits

#6 Updated by Kyle Knoepfel over 3 years ago

  • Description updated (diff)

#7 Updated by Kyle Knoepfel over 3 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF