Project

General

Profile

Task #11761

Milestone #11650: Mar 2016 Release A - 201603A

201602A Replace Vector of Monitors with Map.

Added by Roger Tokarek almost 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Hygiene
Start date:
02/18/2016
Due date:
% Done:

100%

Estimated time:
24.00 h
Spent time:
Duration:

Description

  1. We currently iterate over a vector of monitors to associate a logical ID (SSDN Channel field) with its corresponding hardware ADC and Channel. Replacing the vector with a map container provides simplified, more readable code by removing iteration over the vector. The map key is either the Acnet device SSDN Channel field or a unique index if there is not an associated Acnet device.
  2. As part of this modification, the usage of the parameter name ssdnCh will also be modified throughout the code to become intId, an abbreviation of intensityId, where intId is a more generic, less specific, logical identifier of the ADC/Channel pair. The value intId must be unique and will correspond to an associated Acnet device SSDN Channel field if one is required.

Example

intId ties the following calls to each other:


addMirrToroid( uint16_t adcId, uint16_t adcCh, uint16_t intId );
addATRLatchDev( uint16_t latchId, uint16_t intId, ... ); 
intensityread( uint16_t intId );
std::map<uint16_t, IntMonitorDev*> _monitorTable; // key intId

History

#1 Updated by Roger Tokarek almost 4 years ago

There are approximately 32 VMEInt functions that access class IntMonitorDev via the vector _monitors. Re-estimating the time for this project from 4 hours to 24 - includes possible addition of a map replacement of a vector in DAQPool to extend and complement the changes in VMEInt.

#2 Updated by Roger Tokarek almost 4 years ago

  • Estimated time changed from 4.00 h to 24.00 h

#3 Updated by John Diamond almost 4 years ago

  • Parent task changed from #11649 to #11650

#4 Updated by John Diamond over 3 years ago

  • Status changed from New to Assigned
  • % Done changed from 0 to 100

#5 Updated by Roger Tokarek over 3 years ago

  • Status changed from Assigned to Resolved

#6 Updated by Elliott McCrory about 3 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF