Project

General

Profile

Bug #11628

Pedestal passed by mutable reference in raw.cxx

Added by David Adams almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jonathan Insler
Category:
-
Target version:
-
Start date:
02/04/2016
Due date:
% Done:

100%

Estimated time:
Occurs In:
Experiment:
-
Co-Assignees:
Duration:

Description

In lardata/RawData/raw.h, the pedestal type is int& but the ADC type is short and the pedestal should not be modified during compression/ZS or its inverse.

Can we change the type int& --> short or int (no reference). Or at least make it const&.

If I have somehow misunderstood, could we add a comment explaining why the pedestal is changed?

Thank you.

da

History

#1 Updated by Thomas Junk almost 5 years ago

  • Assignee changed from Gianluca Petrillo to Jonathan Insler

#2 Updated by Jonathan Insler almost 5 years ago

David Adams wrote:

In lardata/RawData/raw.h, the pedestal type is int& but the ADC type is short and the pedestal should not be modified during compression/ZS or its inverse.

Can we change the type int& --> short or int (no reference). Or at least make it const&.

If I have somehow misunderstood, could we add a comment explaining why the pedestal is changed?

Thank you.

da

I have updated the type of the pedestals to int.

#3 Updated by Jonathan Insler almost 5 years ago

  • % Done changed from 0 to 100

#4 Updated by Lynn Garren almost 5 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF