Project

General

Profile

Necessary Maintenance #11468

Clean larsim/Simulation/SimPhotons.h from DUNE code

Added by Gianluca Petrillo almost 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Simulation
Target version:
-
Start date:
01/21/2016
Due date:
% Done:

0%

Estimated time:
Experiment:
DUNE
Duration:

Description

The file larsim/Simulation/SimPhotons.h (line 73 in LArSoft v05_00_00_rc2) contains a comment:

/// \todo: Remove this class when DUNE makes the next round of production
/// MC files - after 11 September 2013 brebel
class DUNE10ktPhotons

(note that the automatic LBNE -> DUNE renaming did work...)
DUNE should state if that is still needed. If so, a better solution needs to be devised.


Related issues

Has duplicate LArSoft - Bug #10741: Move or remove sim::DUNE10ktPhotons class from larsimClosed11/03/2015

History

#1 Updated by Gianluca Petrillo almost 5 years ago

  • Status changed from New to Feedback

#2 Updated by Tingjun Yang almost 5 years ago

Alex should comment on this.

#3 Updated by Alexander Himmel almost 5 years ago

Tingjun Yang wrote:

Alex should comment on this.

OK, so the DUNE10kT photons class was an early attempt at simulating the full sized DUNE (then LBNE) detector written by Zepeng. It was needed because the libraries just weren't working for the full-sized detector. This is not in use, but that is because we simply do not simulate photons in the full-sized detector yet. So, I guess I wouldn't object to removing this since it hasn't been used since then but we don't have "something better" to replace it with at this stage, and probably won't for some time.

#4 Updated by Gianluca Petrillo almost 5 years ago

  • Has duplicate Bug #10741: Move or remove sim::DUNE10ktPhotons class from larsim added

#5 Updated by Katherine Lato over 4 years ago

From an email conversation on 9/29/16, the plan is to assign this to someone who is already working near the code, but not until the current task is completed. (Alex will give the name in a month.) Also will close the duplicated issue, #10741.

Alex noted that need to remove the "Parameterized photon transport" that fills that class, not sure what it will break so some investigation is required. On the plus side, removing the code will avoid the confusion that occurred recently by a student working on implementing a backtracker for the photon simulation.

#6 Updated by Alexander Himmel about 4 years ago

  • Status changed from Feedback to Assigned
  • Assignee set to Jason Stock

#7 Updated by Jason Stock almost 4 years ago

The UseParamaterization method was removed with the implementation of the PhotonBackTracker.
I haven't committed the removal of DUNE10ktPhotons yet, but will do so soon.

#8 Updated by Jason Stock almost 4 years ago

Commit 639a306...15f16a2 develop->develop lardataobj.

Removing the DUNE10ktPhotons class from SimPhotons.h

This changes the classes_defs.xml file.

#9 Updated by Jason Stock almost 4 years ago

  • Status changed from Assigned to Resolved

#10 Updated by Jason Stock almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF