Project

General

Profile

Bug #11043

Fix conditional compilation tests on art version

Added by Kurt Biery over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
v1_12_15
Start date:
12/01/2015
Due date:
% Done:

0%

Estimated time:
Experiment:
-
Co-Assignees:
Duration:

Description

This is minor, but...

At the moment, the pre-processor tests have the form:

#if ART_MAJOR_VERSION >= 1 && ART_MINOR_VERSION >= 16

This will not have the desired effect for art 2.0.x...

History

#1 Updated by Kurt Biery about 4 years ago

  • Target version changed from v1_12_14 to artdaq Next Release

#2 Updated by Kurt Biery about 4 years ago

  • Target version changed from artdaq Next Release to v1_12_15

#3 Updated by Kurt Biery about 4 years ago

  • Status changed from New to Resolved

This was fixed as part of reacting to art changes in art v1_18_05.

Here is a sample diff that shows the change:

-#if ART_MAJOR_VERSION >= 1 && ART_MINOR_VERSION >= 16
+#if (ART_MAJOR_VERSION == 1 && ART_MINOR_VERSION >= 18) || ART_MAJOR_VERSION > 1
+  : OutputModule(ps), initMsgSent_(false)
+#elif ART_MAJOR_VERSION >= 1 && ART_MINOR_VERSION >= 16

#4 Updated by Eric Flumerfelt almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF