Project

General

Profile

Feature #10886

Allow service ctor without ActivityRegistry

Added by David Adams almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Infrastructure
Target version:
Start date:
11/09/2015
Due date:
% Done:

100%

Estimated time:
8.00 h
Spent time:
Scope:
Internal
Experiment:
DUNE
SSI Package:
art
Duration:

Description

Classes that are to be treated as art services are required to provide a ctor with the signature

MyService(fhicl::ParameterSet const &, art::ActivityRegistry &);

but many services do make use of the second argument. Those classes would be cleaner if they were allowed to instead provide a ctor with the signature:

MyService(fhicl::ParameterSet const &);

I request this chage be made to art and am will to help with the implementation.

Thank you.

David

History

#1 Updated by Christopher Green almost 5 years ago

  • Category set to Infrastructure
  • Status changed from New to Accepted
  • Target version set to 2.01.00
  • Estimated time set to 8.00 h
  • SSI Package art added
  • SSI Package deleted ()

We can provide an alternative declare and / or define macro pair to allow this with the next minor version of art. In the meantime, the following workaround will give you the equivalent behavior:

namespace art {
  class ActivityRegistry;
}

...

MyService::MyService(fhicl::ParameterSet const & ps, art::ActivityRegistry & /* unused */)
{
  ...
}

#2 Updated by Kyle Knoepfel over 4 years ago

  • Target version changed from 2.01.00 to Vega

#3 Updated by Christopher Green over 4 years ago

  • Status changed from Accepted to Resolved
  • Assignee set to Christopher Green
  • Target version changed from Vega to 2.00.01
  • % Done changed from 0 to 100

Implemented and tested with commit e202565.

#4 Updated by Kyle Knoepfel over 4 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF