Project

General

Profile

Bug #10141

uboonedaq_datatypes dependency of uboonecode is not optional any more

Added by Gianluca Petrillo almost 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
09/14/2015
Due date:
% Done:

0%

Estimated time:
Duration:

Description

With commit 723d2ade dated September 4th, uboonecode dependency on uboonedaq_datatypes is not optional any more (that is: build fails if uboonedaq_datatypes is not available).

There are two directories that claim to need uboonedaq_datatypes:
  1. uboone/RawData/utils
  2. uboone/BeamData

The former (1) is pulled in by uboone/RawData/CMakeLists.txt only if uboonedaq_datatypes is set up. That allows the dependency to be optional.

On the other hand, uboone/CMakeLists.txt unconditionally pulls in the latter (2), making the dependency required.

There are two possible solutions:
  1. have the dependency on uboonedaq_datatypes mandatory
    • remove the optional flag from uboonedaq_datatypes in ups/product_deps
    • move the find_ups_product( uboonedaq_datatypes v6_13_07 ) line from uboone/BeamData/CMakeLists.txt and uboone/RawData/utils/CMakeLists.txt into CMakeLists.txt
  2. have BeamData, together with the dependency on uboonedaq_datatypes, as optional
    • protect the inclusion of uboone/BeamData in uboone/CMakeLists.txt in a way similar to how it's done in uboone/RawData/CMakeLists.txt (commit 21314401)

Related issues

Related to uBooNE code - Bug #10844: Inconsistent dependencies in uboonecodeRejected2015-11-06

History

#1 Updated by Gianluca Petrillo almost 4 years ago

I have talked with Zarko Pavlovic, who tells me BeamData library should have the same form of dependency as RawData/utils.
I have published the simple change I have used to move on, as branch feature/gp_Issue10141 in uboonecode (commit 5de64e0b).
I have tested it on a machine where uboonedaq_datatypes is not present, and it seems to build fine.

#2 Updated by Gianluca Petrillo almost 4 years ago

  • Status changed from New to Resolved

Katherine has picked the changes, tested them and merged into develop branch.
I have tested that it indeed works.

#3 Updated by Gianluca Petrillo almost 4 years ago

  • Related to Bug #10844: Inconsistent dependencies in uboonecode added

#4 Updated by Katherine Lato about 3 years ago

  • Status changed from Resolved to Closed


Also available in: Atom PDF