Bug #10141
uboonedaq_datatypes dependency of uboonecode is not optional any more
0%
Description
With commit 723d2ade dated September 4th, uboonecode
dependency on uboonedaq_datatypes
is not optional any more (that is: build fails if uboonedaq_datatypes
is not available).
uboone/RawData/utils
uboone/BeamData
The former (1) is pulled in by uboone/RawData/CMakeLists.txt
only if uboonedaq_datatypes
is set up. That allows the dependency to be optional.
On the other hand, uboone/CMakeLists.txt
unconditionally pulls in the latter (2), making the dependency required.
- have the dependency on
uboonedaq_datatypes
mandatory- remove the
optional
flag fromuboonedaq_datatypes
inups/product_deps
- move the
find_ups_product( uboonedaq_datatypes v6_13_07 )
line fromuboone/BeamData/CMakeLists.txt
anduboone/RawData/utils/CMakeLists.txt
intoCMakeLists.txt
- remove the
- have
BeamData
, together with the dependency onuboonedaq_datatypes
, as optional- protect the inclusion of
uboone/BeamData
inuboone/CMakeLists.txt
in a way similar to how it's done inuboone/RawData/CMakeLists.txt
(commit 21314401)
- protect the inclusion of
Related issues
History
#1 Updated by Gianluca Petrillo over 5 years ago
I have talked with Zarko Pavlovic, who tells me BeamData
library should have the same form of dependency as RawData/utils
.
I have published the simple change I have used to move on, as branch feature/gp_Issue10141
in uboonecode
(commit 5de64e0b).
I have tested it on a machine where uboonedaq_datatypes
is not present, and it seems to build fine.
#2 Updated by Gianluca Petrillo over 5 years ago
- Status changed from New to Resolved
Katherine has picked the changes, tested them and merged into develop
branch.
I have tested that it indeed works.
#3 Updated by Gianluca Petrillo about 5 years ago
- Related to Bug #10844: Inconsistent dependencies in uboonecode added
#4 Updated by Katherine Lato over 4 years ago
- Status changed from Resolved to Closed